netdev - Re: [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618091010.GB26461@leverpostej>
Date:	Wed, 18 Jun 2014 10:10:10 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"alex.bluesman.smirnov@...il.com" <alex.bluesman.smirnov@...il.com>,
	"dbaryshkov@...il.com" <dbaryshkov@...il.com>,
	"linux-zigbee-devel@...ts.sourceforge.net" 
	<linux-zigbee-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI
 CC2520 radio

On Wed, Jun 18, 2014 at 06:16:03AM +0100, Varka Bhadram wrote:
> Driver support:
>         - Tx and Rx of IEEE-802.15.4 packets.
>         - Energy Detection on channel.
>         - Setting the Channel for the radio. [b/w 11 - 26 channels]
>         - Start and Stop the radio.
>
> Signed-off-by: Varka Bhadram <varkab@...c.in>
> ---
>  drivers/net/ieee802154/cc2520.c |  968 +++++++++++++++++++++++++++++++++++++++
>  include/linux/spi/cc2520.h      |   26 ++
>  2 files changed, 994 insertions(+)
>  create mode 100644 drivers/net/ieee802154/cc2520.c
>  create mode 100644 include/linux/spi/cc2520.h

[...]

> +static struct cc2520_platform_data *
> +cc2520_get_platform_data(struct spi_device *spi)
> +{
> +       struct cc2520_platform_data *pdata;
> +       struct device_node __maybe_unused *np = spi->dev.of_node;
> +       struct cc2520_private *priv = spi_get_drvdata(spi);
> +
> +       if (!IS_ENABLED(CONFIG_OF) || !np)
> +               return spi->dev.platform_data;

Surely "if (!np)" is good enough?

[...]

> +static int cc2520_probe(struct spi_device *spi)
> +{
> +       struct cc2520_private *priv;
> +       struct pinctrl *pinctrl;
> +       struct cc2520_platform_data *pdata;
> +       struct device_node __maybe_unused *np = spi->dev.of_node;

This looks to be definitely unused rather than __maybe_unused. There are
no other occuences of "np" in this function.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html