netdev - Re: [PATCH net] net: sctp: propagate sysctl errors from proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140618.170341.270139335969927828.davem@davemloft.net>
Date:	Wed, 18 Jun 2014 17:03:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net] net: sctp: propagate sysctl errors from proc_do*
 properly

From: Daniel Borkmann <dborkman@...hat.com>
Date: Thu, 19 Jun 2014 01:31:30 +0200

> sysctl handler proc_sctp_do_hmac_alg(), proc_sctp_do_rto_min() and
> proc_sctp_do_rto_max() do not properly reflect some error cases
> when writing values via sysctl from internal proc functions such
> as proc_dointvec() and proc_dostring().
> 
> In all these cases we pass the test for write != 0 and partially
> do additional work just to notice that additional sanity checks
> fail and we return with hard-coded -EINVAL while proc_do*
> functions might also return different errors. So fix this up by
> simply testing a successful return of proc_do* right after
> calling it.
> 
> This also allows to propagate its return value onwards to the user.
> While touching this, also fix up some minor style issues.
> 
> Fixes: 4f3fdf3bc59c ("sctp: add check rto_min and rto_max in sysctl")
> Fixes: 3c68198e7511 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>

Applied, thanks Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html