netdev - Re: [PATCH] of: mdio: fixup of_phy_register_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A33AD0.2060200@cogentembedded.com>
Date:	Thu, 19 Jun 2014 23:32:32 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Richard Retanubun <rretanubun.work@...il.com>, davem@...emloft.net
CC:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH] of: mdio: fixup of_phy_register_fixed_link parsing of
 new bindings

Hello.

On 06/19/2014 09:35 PM, Richard Retanubun wrote:

> Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

> Fix the parsing of the new fixed link dts bindings for duplex,
> pause, and asym_pause by using the correct device node pointer.

> Signed-off-by: Richard Retanubun <rretanubun.work@...il.com>
> ---
>   drivers/of/of_mdio.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 7700ddc..c389e7b 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
>   	fixed_link_node = of_get_child_by_name(np, "fixed-link");
>   	if (fixed_link_node) {
>   		status.link = 1;
> -		status.duplex = of_property_read_bool(np, "full-duplex");
> +		status.duplex = of_property_read_bool(fixed_link_node,
> +					"full-duplex");

    The continuation line should start under 'fixed_link_node', according to 
the networking coding style.

>   		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
>   			return -EINVAL;
> -		status.pause = of_property_read_bool(np, "pause");
> -		status.asym_pause = of_property_read_bool(np, "asym-pause");
> +		status.pause = of_property_read_bool(fixed_link_node, "pause");
> +		status.asym_pause = of_property_read_bool(fixed_link_node,
> +						"asym-pause");

    Same here...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html