netdev - Re: net: return actual error on register_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+OG=XSc+wx7RLefmiDm8uEegfgEyGtAA8=P+kG1m=n4g@mail.gmail.com>
Date:	Thu, 19 Jun 2014 14:39:41 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"David S. Miller" <davem@...emloft.net>
Cc:	jeff.liu@...cle.com,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: net: return actual error on register_queue_kobjects

On Thu, Jun 19, 2014 at 2:28 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> Hello Jie Liu,
>
> The patch d36a4f4b4723: "net: return actual error on
> register_queue_kobjects" from Jun 17, 2014, leads to the following
> static checker warning:
>
>         net/core/net-sysfs.c:1203 register_queue_kobjects()
>         warn: 'net->queues_kset' isn't an ERR_PTR
>
> net/core/net-sysfs.c
>   1200  #ifdef CONFIG_SYSFS
>   1201          net->queues_kset = kset_create_and_add("queues",
>                                    ^^^^^^^^^^^^^^^^^^^
> This function returns a NULL on error doesn't it?  In linux-next it
> does.  The patch description is not clear.

that patch is broken and should be reverted as Jeff said:

--
From: Jeff Liu <jeff.liu@...cle.com>

> You will have to watch very carefully to ensure that those patches do
> not now get accepted, as they will break the existing code.

Ok, and I'll inform every other maintainers do not apply their patch
individually.

Cheers,
-Jeff

--

From: Jeff Liu <jeff.liu@...cle.com>
Yes, could you please remove this patch? sorry for the convenient!

--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html