netdev - Re: [PATCH 2/2] ipv6: Allow accepting RA from local IP addresses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403278836.22173.21.camel@localhost>
Date:	Fri, 20 Jun 2014 17:40:36 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv6:  Allow accepting RA from local IP addresses.

On Mi, 2014-06-18 at 10:50 -0700, greearb@...delatech.com wrote:
> From: Ben Greear <greearb@...delatech.com>
> 
> This can be used in virtual networking applications, and
> may have other uses as well.  The option is disabled by
> default, so no change to current operating behaviour
> without the user explicitly changing the behaviour.

Can you give a specific example for its use case? I currently don't see
the need for such an option.

> -	if (ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> +	if (!(in6_dev->cnf.accept_ra_from_local ||
> +	      dev_net(in6_dev->dev)->ipv6.devconf_all->accept_ra_from_local) &&
> +	    ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
>  			  NULL, 0)) {
>  		ND_PRINTK(2, info,
>  			  "RA: %s, chk_addr failed for dev: %s\n",
> @@ -1293,7 +1295,9 @@ skip_linkparms:
>  	}
>  
>  #ifdef CONFIG_IPV6_ROUTE_INFO
> -	if (ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
> +	if (!(in6_dev->cnf.accept_ra_from_local ||
> +	      dev_net(in6_dev->dev)->ipv6.devconf_all->accept_ra_from_local) &&
> +	    ipv6_chk_addr(dev_net(in6_dev->dev), &ipv6_hdr(skb)->saddr,
>  			  NULL, 0)) {
>  		ND_PRINTK(2, info,
>  			  "RA: %s, chk-addr (route info) is false for dev: %s\n",

Maybe ipv6_accept_ra_local() like ipv6_accept_ra() static local to the
file?

Also I am not sure if we want to provide an devconf_all for this setting
at all, like we don't evaluate it for accept_ra, too. At least I
wouldn't do so with the current state of ipv6/conf/{all,default}.

Bye,
Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html