netdev - Re: [PATCH net]tg3: Clear NETIF_F_TSO6 flag before doing software GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403241085.2488.53.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Thu, 19 Jun 2014 22:11:25 -0700
From:	Michael Chan <mchan@...adcom.com>
To:	David Miller <davem@...emloft.net>
CC:	<prashant@...adcom.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net]tg3: Clear NETIF_F_TSO6 flag before doing software
 GSO

On Thu, 2014-06-19 at 20:56 -0700, David Miller wrote: 
> From: Prashant Sreedharan <prashant@...adcom.com>
> Date: Wed, 18 Jun 2014 18:38:13 -0700
> 
> > Commit d3f6f3a1d818410c17445bce4f4caab52eb102f1 "tg3: Prevent page
> > allocation failure during TSO workaround" modified driver logic
> > to use tg3_tso_bug() for any TSO fragment that hits hardware bug
> > conditions thus the patch increased the scope of work for tg3_tso_bug()
> > to cover devices that support NETIF_F_TSO6 as well. Prior to the
> > patch, tg3_tso_bug() would only be used on devices supporting
> > NETIF_F_TSO.
> > 
> > A regression was introduced for IPv6 packets requiring the workaround.
> > To properly perform GSO on SKBs with TCPV6 gso_type, we need to call
> > skb_gso_segment() with NETIF_F_TSO6 feature flag cleared, or the
> > function will return NULL and cause a kernel oops as tg3 is not handling
> > a NULL return value. This patch fixes the problem.
> > 
> > Signed-off-by: Prashant Sreedharan <prashant@...adcom.com>
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> 
> Applied and queued up for -stable, thanks.

David, the regression is only in the net tree.  It doesn't hurt to send
the patch to -stable, but not necessary.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html