netdev - Re: [PATCH net] be2net: fix qnq mode detection on VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 14:47:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: fix qnq mode detection on VFs

From: Sathya Perla <sathya.perla@...lex.com>
Date: Mon, 23 Jun 2014 16:41:29 +0530

> From: Suresh Reddy <suresh.reddy@...lex.com>
> 
> The driver (on PF or VF) needs to detect if the function is in qnq mode for
> a HW hack in be_rx_compl_get() to work.
> 
> The driver queries this information using the GET_PROFILE_CONFIG cmd
> (since the commit below can caused this regression.) But this cmd is not
> available on VFs and so the VFs fail to detect qnq mode. This causes
> vlan traffic to not work.
> 
> The fix is to use the the adapter->function_mode value queried via
> QUERY_FIRMWARE_CONFIG cmd on both PFs and VFs to detect the qnq mode.
> 
> Also QNQ_MODE was incorrectly named FLEX10_MODE; correcting that too as the
> fix reads much better with the name change.
> 
> Fixes: f93f160b5 ("refactor multi-channel config code for Skyhawk-R chip")
> 
> Signed-off-by: Suresh Reddy <Suresh.Reddy@...lex.com>
> Signed-off-by: Sathya Perla <sathya.perla@...lex.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html