netdev - Re: [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock when read adap_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140623.145035.915335524137481573.davem@davemloft.net>
Date:	Mon, 23 Jun 2014 14:50:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rongqing.li@...driver.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	hariprasad@...lsio.com, leedom@...lsio.com, greearb@...delatech.com
Subject: Re: [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock
 when read adap_rcu_list

From: <rongqing.li@...driver.com>
Date: Fri, 20 Jun 2014 17:32:36 +0800

> cxgb4_netdev maybe lead to dead lock, since it uses a spin lock, and be called
> in both thread and softirq context, but not disable BH, the lockdep report is
> below; In fact, cxgb4_netdev only reads adap_rcu_list with RCU protection, so
> not need to hold spin lock again.

I think this change is fine, and correct, but I would like to see some
reviews from the cxgb4 maintainers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html