lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jun 2014 11:20:56 +0900 From: Simon Horman <horms@...ge.net.au> To: Fabian Frederick <fabf@...net.be> Cc: linux-kernel@...r.kernel.org, Wensong Zhang <wensong@...ux-vs.org>, netdev@...r.kernel.org Subject: Re: [PATCH 1/1] net/netfilter/ipvs/ip_vs_sync.c: remove null test before kfree On Fri, Jun 20, 2014 at 10:35:42PM +0200, Fabian Frederick wrote: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required > > Cc: Wensong Zhang <wensong@...ux-vs.org> > Cc: Simon Horman <horms@...ge.net.au> > Cc: netdev@...r.kernel.org > Signed-off-by: Fabian Frederick <fabf@...net.be> Thanks, applied. > --- > net/netfilter/ipvs/ip_vs_sync.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c > index db80126..eadffb2 100644 > --- a/net/netfilter/ipvs/ip_vs_sync.c > +++ b/net/netfilter/ipvs/ip_vs_sync.c > @@ -886,8 +886,7 @@ static void ip_vs_proc_conn(struct net *net, struct ip_vs_conn_param *param, > cp = ip_vs_conn_new(param, daddr, dport, flags, dest, fwmark); > rcu_read_unlock(); > if (!cp) { > - if (param->pe_data) > - kfree(param->pe_data); > + kfree(param->pe_data); > IP_VS_DBG(2, "BACKUP, add new conn. failed\n"); > return; > } > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists