netdev - Re: [PATCH net v2] xen-netback: bookkeep number of active queues in our own module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140623.021110.1153969828079234680.davem@davemloft.net>
Date:	Mon, 23 Jun 2014 02:11:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wei.liu2@...rix.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	boris.ostrovsky@...cle.com, ian.campbell@...rix.com
Subject: Re: [PATCH net v2] xen-netback: bookkeep number of active queues
 in our own module

From: Wei Liu <wei.liu2@...rix.com>
Date: Mon, 23 Jun 2014 09:40:32 +0100

> On Sun, Jun 22, 2014 at 05:21:05PM -0700, David Miller wrote:
>> From: Wei Liu <wei.liu2@...rix.com>
>> Date: Sun, 22 Jun 2014 14:31:41 +0100
>> 
>> >  
>> > +	/* Initialisation completed, tell core driver the number of
>> > +	 * active queues.
>> > +	 */
>> > +	rtnl_lock();
>> > +	netif_set_real_num_tx_queues(be->vif->dev, requested_num_queues);
>> > +	netif_set_real_num_rx_queues(be->vif->dev, requested_num_queues);
>> > +	rtnl_unlock();
>> > +
>> >  	xenvif_carrier_on(be->vif);
>> 
>> This function _NEVER_ set the number of RX queues beforehand,
>> therefore why are you adding an RX queue adjustment now?
>> 
> 
> As I went through the core driver code I found this to be a missing call
> in previous code.
> 
> "In current Xen multiqueue design, the number of TX queues and RX queues
> are in fact the same. So we need to set the numbers of TX and RX queues
> to the same value."
> 
> Does the above paragraph answers your question? If so, I will add it to
> commit message and resend this patch.

Yes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html