netdev - Re: [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock when read adap_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140624.155410.802407476153586247.davem@davemloft.net>
Date:	Tue, 24 Jun 2014 15:54:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rongqing.li@...driver.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	hariprasad@...lsio.com, leedom@...lsio.com, greearb@...delatech.com
Subject: Re: [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock
 when read adap_rcu_list

From: <rongqing.li@...driver.com>
Date: Fri, 20 Jun 2014 17:32:36 +0800

> From: Li RongQing <roy.qing.li@...il.com> 
> 
> cxgb4_netdev maybe lead to dead lock, since it uses a spin lock, and be called
> in both thread and softirq context, but not disable BH, the lockdep report is
> below; In fact, cxgb4_netdev only reads adap_rcu_list with RCU protection, so
> not need to hold spin lock again.
 ...
> Reported-by: Ben Greear <greearb@...delatech.com>
> Cc: Casey Leedom <leedom@...lsio.com>
> Cc: Hariprasad Shenai <hariprasad@...lsio.com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks.

Casey please _do not_ put indentation in front of your Acked-by:,
automated tools like patchwork will not pick it up if you do that.

I'm actually very surprised how much spurious indentation and weird
spacing shows up in some people's postings.  You folks definitely are
using graphical tools to type this stuff in, rather than real pure
text editors.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html