netdev - Re: [PATCH 00/22] Add and use pci_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403609569.10831.0.camel@jlt4.sipsolutions.net>
Date:	Tue, 24 Jun 2014 13:32:49 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Julian Calaby <julian.calaby@...il.com>
Cc:	Joe Perches <joe@...ches.com>,
	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	linux-arch@...r.kernel.org,
	linux-scsi <linux-scsi@...r.kernel.org>, iss_storagedev@...com,
	linux-rdma@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	linux-atm-general@...ts.sourceforge.net,
	linux-wireless <linux-wireless@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org, linux-crypto@...r.kernel.org,
	linux-eata@...onnect.net, linux-media@...r.kernel.org
Subject: Re: [PATCH 00/22] Add and use pci_zalloc_consistent

On Tue, 2014-06-24 at 09:27 +1000, Julian Calaby wrote:

> > - x = (T)pci_alloc_consistent(E1,E2,E3);
> > + x = pci_zalloc_consistent(E1,E2,E3);
> >   if ((x==NULL) || ...) S
> > - memset((T2)x,0,E2);
> 
> I don't know much about SmPL, but wouldn't having that if statement
> there reduce your matches?

Code that matched without the if statement would be buggy, since it
wouldn't be checking the pci_zalloc_consistent return value properly.l

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html