netdev - Re: [PATCH] cxgb4: Fix endian bug introduced in 76bcb31efc0685574fb123f7aaa92f8a50c14fd9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 17:55:54 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Anish Bhatt <anish@...lsio.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, leedom@...lsio.com, hariprasad@...lsio.com
Subject: Re: [PATCH] cxgb4: Fix endian bug introduced in 76bcb31efc0685574fb123f7aaa92f8a50c14fd9

Hello.

On 06/24/2014 04:27 AM, Anish Bhatt wrote:

    Please move the "introduced by <SHA1>" part of the subject into the 
changelog and add to <SHA1> the summary line of that commit in enclosed in 
parens. You can also add:

Fixes: <12-digit SHA1> ("<commit summary>")

before your signoff.

> Signed-off-by: Anish Bhatt <anish@...lsio.com>
> ---
>   drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> index 39b4a85..a8b1073 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> @@ -488,12 +488,12 @@ static void cxgb4_setpfccfg(struct net_device *dev, int priority, u8 pfccfg)
>   		pcmd.op_to_portid |= cpu_to_be32(FW_PORT_CMD_APPLY);
>
>   	pcmd.u.dcb.pfc.type = FW_PORT_DCB_TYPE_PFC;
> -	pcmd.u.dcb.pfc.pfcen = cpu_to_be16(pi->dcb.pfcen);
> +	pcmd.u.dcb.pfc.pfcen = pi->dcb.pfcen;
>
>   	if (pfccfg)
> -		pcmd.u.dcb.pfc.pfcen |= cpu_to_be16(1 << priority);
> +		pcmd.u.dcb.pfc.pfcen |= (1 << priority);
>   	else
> -		pcmd.u.dcb.pfc.pfcen &= cpu_to_be16(~(1 << priority));
> +		pcmd.u.dcb.pfc.pfcen &= (~(1 << priority));

    Outer () not needed here and above.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html