netdev - Re: [PATCH 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJPoy_z-WoqEXnSvTZ-ussCRawn9L5eBfo6S_gxY2MMwQ@mail.gmail.com>
Date:	Tue, 24 Jun 2014 08:29:46 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Denis Kirjanov <kda@...ux-powerpc.org>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: bpf: Use correct mask while accessing the
 VLAN tag

On Tue, Jun 24, 2014 at 2:59 AM, Denis Kirjanov <kda@...ux-powerpc.org> wrote:
> Use the proper mask which is 0xefff

sob is missing.

also please expand the commit message a bit, otherwise it's too cryptic for
folks who don't know bpf details.

> ---
>  arch/powerpc/net/bpf_jit_comp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c
> index 6dcdade..af0ed4d 100644
> --- a/arch/powerpc/net/bpf_jit_comp.c
> +++ b/arch/powerpc/net/bpf_jit_comp.c
> @@ -393,7 +393,7 @@ static int bpf_jit_build_body(struct sk_filter *fp, u32 *image,
>                         PPC_LHZ_OFFS(r_A, r_skb, offsetof(struct sk_buff,
>                                                           vlan_tci));
>                         if (code == (BPF_ANC | SKF_AD_VLAN_TAG))
> -                               PPC_ANDI(r_A, r_A, VLAN_VID_MASK);
> +                               PPC_ANDI(r_A, r_A, ~VLAN_TAG_PRESENT);
>                         else
>                                 PPC_ANDI(r_A, r_A, VLAN_TAG_PRESENT);
>                         break;
> --
> 2.0.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html