netdev - Re: [patch net-next 2/2] openvswitch: introduce rtnl ops stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877g44x68q.fsf@x220.int.ebiederm.org>
Date:	Wed, 25 Jun 2014 10:13:09 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, pshelar@...ira.com,
	cwang@...pensource.com, nicolas.dichtel@...nd.com,
	david@...son.dropbear.id.au, sfeldma@...ulusnetworks.com,
	sucheta.chakraborty@...gic.com, stephen@...workplumber.org
Subject: Re: [patch net-next 2/2] openvswitch: introduce rtnl ops stub

Jiri Pirko <jiri@...nulli.us> writes:

> Wed, Jun 25, 2014 at 06:02:42PM CEST, ebiederm@...ssion.com wrote:
>>Jiri Pirko <jiri@...nulli.us> writes:
>>
>>> This stub now allows userspace to see IFLA_INFO_KIND for ovs master and
>>> IFLA_INFO_SLAVE_KIND for slave.
>>
>>I am puzzled why you don't implement full rtnl_link_operations support.
>
> openvswitch does not need that at the moment (most probably it never
> will). Creation and deletion is handled over separate genl channel.
>
>>
>>If all you want is to report which kind of driver you have I suspect
>>implementing ethtool_ops.get_drvinfo is a much better fit.
>
> That is maybe partly true but that would not be consistent with bond, team,
> bridge masters and slaves which benefit ops->kind to expose the type
> into userspace.

So instead of using the mechanism that is supported by most of the
network drivers in the tree you are instead relying on a mechanism
that only works for a handful of software defined network devices.

I really think exposing a kind at this point is lying to user space
as having a kind implies that the netlink messages behind "ip link add"
and "ip link del" work.

Further I have seen nothing in what you are proposing that addresses
that absolute horrible maintenance consequences of your patch.

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html