netdev - Re: [PATCH] udp: Add MIB counters for rcvbuferrors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AB3FAF.409@redhat.com>
Date:	Wed, 25 Jun 2014 17:31:27 -0400
From:	James M Leddy <james.leddy@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] udp: Add MIB counters for rcvbuferrors

On 06/21/2014 06:07 PM, David Miller wrote:
> From: James M Leddy <james.leddy@...hat.com>
> Date: Tue, 17 Jun 2014 16:13:02 -0400
>
>> Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
>>
>> Signed-off-by: James M Leddy <james.leddy@...hat.com>
>
> Please compile test your patches:
>
> net/ipv4/udp.c: In function ‘udp_queue_rcv_skb’:
> net/ipv4/udp.c:1538:5: error: label ‘csum_error’ used but not defined
> make[1]: *** [net/ipv4/udp.o] Error 1
> make: *** [net/ipv4/udp.o] Error 2
>
> The encapsulation handling above your changes still use that label.
>
> Besides, I see no reason to replace the goto csum_error; with
> doing the counter bump by hand and jumping to "drop".  Especially
> since, as per above, there is another code path which can make
> use of and thus share that csum_error label code.

My bad, resending


-- 
James M Leddy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html