netdev - Re: [RFC net-next 03/12] net: remove inet6_reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140625.161733.1604668220222889933.davem@davemloft.net>
Date:	Wed, 25 Jun 2014 16:17:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	octavian.purdila@...el.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC net-next 03/12] net: remove inet6_reqsk_alloc

From: Octavian Purdila <octavian.purdila@...el.com>
Date: Mon, 23 Jun 2014 21:42:40 +0300

> Since pktops is only used for IPv6 only and opts is used for IPv4
> only, we can move these fields into a union and this allows us to drop
> the inet6_reqsk_alloc function as after this change it becomes
> equivalent with inet_reqsk_alloc.
> 
> This patch also fixes an kmemcheck issue in the IPv6 stack: the flags
> field was not annotated after a request_sock was allocated.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>

What about ipv4 mapped ipv6 connections?  I don't think it's safe to
share the space for these two fields.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html