netdev - Re: [net-next v2 03/14] i40e: Add PF reset when Malicious driver event for PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403662597.12657.4.camel@joe-AO725>
Date:	Tue, 24 Jun 2014 19:16:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Neerav Parikh <neerav.parikh@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next v2 03/14] i40e: Add PF reset when Malicious driver
 event for PF

On Tue, 2014-06-24 at 18:26 -0700, Jeff Kirsher wrote:
> From: Neerav Parikh <neerav.parikh@...el.com>
> 
> As per the spec when the PF driver receives a Malicious driver event
> the queue that caused the event is already stopped and it is expected
> that the function that owns the queue will reset the queue.
> In some cases it may not be possible to determine the queue and it is
> suggested to reset the whole function.
> 
> This patch takes the later approach when the event is owned by the PF
> that owns it.
> 
> Change-ID: I40f9764a6a5e068c0ef8438db00c5aa9c2c6c1c8
> Signed-off-by: Neerav Parikh <neerav.parikh@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> v2: added punctuation to print statements and code comment

Comments are good, but I'd suggest removing trailing
periods from messages as close to 95% of the messages
in this driver do not use them.

$ grep -rP --include=*.[ch] -oh '.\\n"' drivers/net/ethernet/intel/i40e/| \
  sed 's/[^\.]\\n/X\\n/' | sort | uniq -c | sort -rn
    621 X\n"
     41 .\n"


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html