lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jun 2014 10:36:02 +0200 From: Daniel Borkmann <dborkman@...hat.com> To: Michael Ellerman <mpe@...erman.id.au> CC: Denis Kirjanov <kda@...ux-powerpc.org>, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test On 06/26/2014 10:30 AM, Michael Ellerman wrote: > On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote: >> We have to return the boolean here if the tag presents >> or not, not just ANDing the TCI with the mask which results to: >> >> [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT >> [ 709.412245] ret 4096 != 1 >> [ 709.412332] ret 4096 != 1 >> [ 709.412333] FAIL (2 times) > > Hi Denis, > > Is this the same version of test_bpf that is in Linus' tree? > > I don't see any fails with that version, am I missing something? > > [ 187.690640] test_bpf: #18 LD_VLAN_TAG_PRESENT 46 50 PASS Did you try to modprobe test_bpf after enabling JIT, i.e. : echo 1 > /proc/sys/net/core/bpf_jit_enable Last time I tested with ppc64, I saw the interpreter passing while JIT failed, which the fix above should address. Cheers, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists