netdev - Re: [PATCH] cxgb4: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140626123709.GA9256@oc0268524204.ibm.com>
Date:	Thu, 26 Jun 2014 09:37:09 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Hariprasad Shenai <hariprasad@...lsio.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxgb4: use dev_port to identify ports

On Wed, Jun 25, 2014 at 04:08:21PM -0700, Luis R. Rodriguez wrote:
> On Sat, Jun 21, 2014 at 5:48 AM, Thadeu Lima de Souza Cascardo
> <cascardo@...ux.vnet.ibm.com> wrote:
> > That use was removed by commit
> > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set
> > net_device::dev_id to VI index"), since dev_id should be used only when
> > devices share the same MAC address.
> >
> > Using dev_port for cxgb4 allows different ports on the same PCI function
> > to be identified.
> 
> Can you describe what issues were introduced because of this then?
> 
>   Luis
> 

udevd builtin net-id cannot rename the interfaces, since it relies on
the dev_id for interfaces on the same PCI function. I am going to send a
patch to use dev_port instead, and fallback to dev_id, and copy netdev.

Regards.
Cascardo.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html