netdev - Re: [PATCH] net: fix circular dependency in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140627.124510.393574473550421757.davem@davemloft.net>
Date:	Fri, 27 Jun 2014 12:45:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zonque@...il.com
Cc:	jeffm@...e.com, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix circular dependency in of_mdio code

From: David Miller <davem@...emloft.net>
Date: Fri, 27 Jun 2014 00:26:26 -0700 (PDT)

> From: Daniel Mack <zonque@...il.com>
> Date: Thu, 26 Jun 2014 09:10:31 +0200
> 
>> Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a
>> circular dependency between libphy and of_mdio.
>> 
>> depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
>> dependency cycle!
>> depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!
>> 
>> The problem is that of_mdio.c references &mdio_bus_type and libphy now
>> references of_mdiobus_link_phydev.
>> 
>> Fix this by not exporting of_mdiobus_link_phydev() from of_mdio.ko.
>> Make it a static function in mdio_bus.c instead.
>> 
>> Signed-off-by: Daniel Mack <zonque@...il.com>
>> Reported-by: Jeff Mahoney <jeffm@...e.com>
>> Fixes: 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
> 
> Applied, thank you.

This doesn't work, it breaks the build:

drivers/net/phy/mdio_bus.c: In function ‘mdiobus_scan’:
drivers/net/phy/mdio_bus.c:346:2: error: implicit declaration of function ‘of_mdiobus_link_phydev’ [-Werror=implicit-function-declaration]