netdev - Re: [PATCH net-next 0/6] amd-xgbe: AMD 10Gb Ethernet driver updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140626.171513.1599540810911294287.davem@davemloft.net>
Date:	Thu, 26 Jun 2014 17:15:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.lendacky@....com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] amd-xgbe: AMD 10Gb Ethernet driver updates

From: Tom Lendacky <thomas.lendacky@....com>
Date: Tue, 24 Jun 2014 16:19:00 -0500

> The following series fixes some bugs and provides new/changed support
> in the driver.
> 
> - Make all the defines in the xgbe.h file unique by prefixing them with
>   XGBE_ if they are not currently using the prefix.
> - VLAN CTAGs are supplied in context descriptors. Tell the hardware to
>   look in the Tx context descriptor, and not a register, for the VLAN CTAG
>   to be inserted in the packet.
> - The hardware will indicate a VLAN packet has been received even if VLAN
>   CTAG stripping is currently disabled.  Only indicate that a VLAN CTAG
>   has been stripped for the current packet if stripping is enabled.
> - Add support for VLAN filtering
> - Modify destination address filtering to use the hardware hash tables
> - Eliminate a checkpatch warning by replacing sscanf with kstrtouint
> 
> This patch series is based on net-next.

Series applied, but as already mentioned I'm not happy with the debugfs
stuff, and also you didn't need to ifdef protect the definition of the
crc32 little endian polynomial define.  If someone ever puts that in
a generic place (and we should, it shows up in 3 places already) they
will take out your local define surely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html