netdev - Re: [net-next PATCH v3 2/2] bridge: netlink dump interface at par with brctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140626.174530.4353389845713242.davem@davemloft.net>
Date:	Thu, 26 Jun 2014 17:45:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	vyasevic@...hat.com, sfeldma@...ulusnetworks.com,
	john.r.fastabend@...el.com, roopa@...ulusnetworks.com,
	eric.dumazet@...il.com
Subject: Re: [net-next PATCH v3 2/2] bridge: netlink dump interface at par
 with brctl

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Wed, 25 Jun 2014 06:21:23 -0400

> +				/* 
> +				 * !f->dst is a speacial case for bridge
> +				 * It means the MAC belongs to the bridge
> +				 * Therefore need a little more filtering
> +				 * we only want to dump the !f->dst case
> +				 */

Please format comments:

	/* Like
	 * this.
	 */

in the networking.

> +	for_each_netdev(net, dev) {
> +
> +		if (brport_idx && (dev->ifindex != brport_idx))

Please remove that empty line.

> +			if (cops && cops->ndo_fdb_dump) {
> +				idx = cops->ndo_fdb_dump(skb, cb, br_dev, dev, idx);
> +			}

Single statement basic blocks do not need curly braces.

> +		if (dev->netdev_ops->ndo_fdb_dump) {
> +			idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, bdev, dev,
> +							    idx);
>  		}

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html