netdev - Re: [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQyki0a4J9u2+WD7o01b6+3SSjWHSkeU9NGf0h0SWedt2Uw@mail.gmail.com>
Date:	Fri, 27 Jun 2014 22:24:25 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Octavian Purdila <octavian.purdila@...el.com>
Cc:	Netdev <netdev@...r.kernel.org>, Daniel Lee <longinus00@...il.com>,
	Yuchung Cheng <ycheng@...gle.com>, Jerry Chu <hkchu@...gle.com>
Subject: Re: [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt_synack initialization

On Fri, Jun 27, 2014 at 10:16 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
> So I would suggest that we fix this inconsistency you have noted by
> removing the two lines in tcp_v4_send_synack() that touch snt_synack.
> That is the approach we have been using at Google recently, and I
> think it was an oversight that we didn't remove those two lines.

I see David merged the patch series tonight, so since I came late to
the party I'm happy to make and test this change if there is consensus
that this is reasonable.

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html