lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jun 2014 15:54:27 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Vince Bridgers <vbridgers2013@...il.com> Cc: Randy Dunlap <rdunlap@...radead.org>, David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, vbridger@...era.com Subject: Re: [PATCH net v4 3/3] Documentation: networking: phy.txt: Update text for indirect MMD access 2014-06-29 18:35 GMT-07:00 Vince Bridgers <vbridgers2013@...il.com>: > Update the PHY library documentation to describe how a specific PHY > driver can use the PAL MMD register access routines or override those > routines with it's own in the event the PHY does not support the IEEE > standard for reading and writing MMD phy registers. > > Signed-off-by: Vince Bridgers <vbridgers2013@...il.com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> > --- > V4: None > V3: Add modified Documentation/networking/phy.txt per review comments. > --- > Documentation/networking/phy.txt | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/networking/phy.txt b/Documentation/networking/phy.txt > index 3544c98..326836a 100644 > --- a/Documentation/networking/phy.txt > +++ b/Documentation/networking/phy.txt > @@ -272,6 +272,8 @@ Writing a PHY driver > txtsamp: Requests a transmit timestamp at the PHY level for a 'skb' > set_wol: Enable Wake-on-LAN at the PHY level > get_wol: Get the Wake-on-LAN status at the PHY level > + rd_mmd_indirect: Read PHY MMD indirect register > + wr_mmd_indirect: Write PHY MMD indirect register > > Of these, only config_aneg and read_status are required to be > assigned by the driver code. The rest are optional. Also, it is > @@ -284,7 +286,21 @@ Writing a PHY driver > > Feel free to look at the Marvell, Cicada, and Davicom drivers in > drivers/net/phy/ for examples (the lxt and qsemi drivers have > - not been tested as of this writing) > + not been tested as of this writing). > + > + The PHY's MMD register accesses are handled by the PAL framework > + by default, but can be overridden by a specific PHY driver if > + required. This could be the case if a PHY was released for > + manufacturing before the MMD PHY register definitions were > + standardized by the IEEE. Most modern PHYs will be able to use > + the generic PAL framework for accessing the PHY's MMD registers. > + An example of such usage is for Energy Efficient Ethernet support, > + implemented in the PAL. This support uses the PAL to access MMD > + registers for EEE query and configuration if the PHY supports > + the IEEE standard access mechanisms, or can use the PHY's specific > + access interfaces if overridden by the specific PHY driver. See > + the Micrel driver in drivers/net/phy/ for an example of how this > + can be implemented. > > Board Fixups > > -- > 1.7.9.5 > -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists