lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jun 2014 10:58:23 +0100 (BST) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: David Laight <David.Laight@...LAB.COM> cc: 'Joe Perches' <joe@...ches.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH] declance: Fix 64-bit compilation warnings On Mon, 30 Jun 2014, David Laight wrote: > > > @@ -499,8 +499,9 @@ static void lance_init_ring(struct net_d > > > /* The ones required by tmd2 */ > > > *lib_ptr(ib, btx_ring[i].misc, lp->type) = 0; > > > if (i < 3 && ZERO) > > > - printk("%d: 0x%8.8x(0x%8.8x)\n", > > > - i, leptr, (uint)lp->tx_buf_ptr_cpu[i]); > > > + printk("%d: 0x%8.8x(%#0*lx)\n", > > > + i, leptr, (int)sizeof(long), > > > + (long)lp->tx_buf_ptr_cpu[i]); > > > > You need to adjust the "*" and sizeof(long) with +2 for the > > 0x prefix in the output length here. > > Do you need all the leading zeros at all? For output alignment; plus the change is not intended to change semantics, but just to address the lack of 64-bit cleanliness. Maciej -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists