netdev - Re: [PATCH net] tcp: Fix divide by zero when pushing during tcp-repair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B16239.80402@parallels.com>
Date:	Mon, 30 Jun 2014 17:12:25 +0400
From:	Pavel Emelyanov <xemul@...allels.com>
To:	Christoph Paasch <christoph.paasch@...ouvain.be>,
	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, Andrew Vagin <avagin@...nvz.org>
Subject: Re: [PATCH net] tcp: Fix divide by zero when pushing during tcp-repair

On 06/28/2014 08:26 PM, Christoph Paasch wrote:
> When in repair-mode and TCP_RECV_QUEUE is set, we end up calling
> tcp_push with mss_now being 0. If data is in the send-queue and
> tcp_set_skb_tso_segs gets called, we crash because it will divide by
> mss_now:
> 
snip
> Cc: Andrew Vagin <avagin@...nvz.org>
> Cc: Pavel Emelyanov <xemul@...allels.com>
> Fixes: ec3423257508 (tcp: fix retransmission in repair mode)
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>

Acked-by: Pavel Emelyanov <xemul@...allels.com>

Thanks,
Pavel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html