netdev - Re: [PATCH net v2 3/3] net: stmmac: Improve mcast/ucast filter for all Synopsys EMAC Configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOwfj2NGdVGd2iHfbF73U9Jc6VmFQSHfEm7Jevo5WyzYkrDX+A@mail.gmail.com>
Date:	Mon, 30 Jun 2014 09:01:17 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Giuseppe CAVALLARO <peppe.cavallaro@...com>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, linux@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Dinh Nguyen <dinguyen@...era.com>,
	David Miller <davem@...emloft.net>,
	Vince Bridgers <vbridger@...era.com>
Subject: Re: [PATCH net v2 3/3] net: stmmac: Improve mcast/ucast filter for
 all Synopsys EMAC Configurations

 Hi Arnd,

On Mon, Jun 30, 2014 at 1:46 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Sunday 29 June 2014 20:35:10 Vince Bridgers wrote:
>> The synopsys EMAC can be configured for different numbers of multicast hash
>> bins and perfect filter entries at device creation time and there's no way
>> to query this configuration information at runtime. As a result, a devicetree
>> parameter is required in order for the driver to program these filters
>> correctly for a particular device instance. This patch extends the current
>> driver by providing a different multicast filter programming function if
>> different than the currently supported 64 multicast hash bins and 32
>> perfect unicast addresses. This patch is required to correct multicast
>> filtering for the Altera Cyclone V SOC.
>>
>> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
>>
>
> No objections to the content of the patch, but it would be better to split
> it out into two separate patches: one that does the mechanical prototype
> and formatting changes, and a smaller one that actually introduces the
> functional change. That would make it much easier to review, and to bisect
> potential problems when something goes wrong.
>
>         Arnd

I'll make the suggested change and resubmit. Thank you for the suggestion.

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html