lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 30 Jun 2014 09:01:17 -0500
From:	Vince Bridgers <>
To:	Arnd Bergmann <>
Cc:	"" <>,
	"" <>,
	Giuseppe CAVALLARO <>,
	"" <>,
	"" <>,
	"" <>,
	Kumar Gala <>,,,
	"" <>,
	Dinh Nguyen <>,
	David Miller <>,
	Vince Bridgers <>
Subject: Re: [PATCH net v2 3/3] net: stmmac: Improve mcast/ucast filter for
 all Synopsys EMAC Configurations

 Hi Arnd,

On Mon, Jun 30, 2014 at 1:46 AM, Arnd Bergmann <> wrote:
> On Sunday 29 June 2014 20:35:10 Vince Bridgers wrote:
>> The synopsys EMAC can be configured for different numbers of multicast hash
>> bins and perfect filter entries at device creation time and there's no way
>> to query this configuration information at runtime. As a result, a devicetree
>> parameter is required in order for the driver to program these filters
>> correctly for a particular device instance. This patch extends the current
>> driver by providing a different multicast filter programming function if
>> different than the currently supported 64 multicast hash bins and 32
>> perfect unicast addresses. This patch is required to correct multicast
>> filtering for the Altera Cyclone V SOC.
>> Signed-off-by: Vince Bridgers <>
> No objections to the content of the patch, but it would be better to split
> it out into two separate patches: one that does the mechanical prototype
> and formatting changes, and a smaller one that actually introduces the
> functional change. That would make it much easier to review, and to bisect
> potential problems when something goes wrong.
>         Arnd

I'll make the suggested change and resubmit. Thank you for the suggestion.

All the best,

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists