netdev - Re: [PATCH net V1 1/3] net/mlx4_en: Don't use irq_affinity_notifier to track changes in IRQ affinity map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140630.203308.1311350484055713992.davem@davemloft.net>
Date:	Mon, 30 Jun 2014 20:33:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com, amirv.mellanox@...il.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	ogerlitz@...lanox.com, yevgenyp@...lanox.com, tglx@...utronix.de,
	ben@...adent.org.uk, amira@...lanox.com, yuvala@...lanox.com
Subject: Re: [PATCH net V1 1/3] net/mlx4_en: Don't use
 irq_affinity_notifier to track changes in IRQ affinity map

From: Amir Vadai <amirv.mellanox@...il.com>
Date: Mon, 30 Jun 2014 11:34:22 +0300

> On 6/30/2014 9:41 AM, Eric Dumazet wrote:
>> You might want to drain whole queue instead of limiting to a 'budget',
>> otherwise, a cpu might be stuck servicing (soft)irq for the TX
>> completion, even if irq affinities say otherwise.
>> 
> 
> TX completions are very quick compared to the skb preparation and
> sending. Which is not the case for RX completions. Because of that, it
> is very easy to reproduce the problem in RX flows, but we never had any
> report of that problem in the TX flow.
> I prefer not to spend time on the TX, since we plan to send a patch soon
> to use the same NAPI for both TX and RX.

It is always advised to completely ignore the budget for TX work, this is
what we tell every driver author when discussion NAPI implementations.

Please make your driver conform to this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html