netdev - Re: [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver for QCA7000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404237465.14624.9.camel@joe-AO725>
Date:	Tue, 01 Jul 2014 10:57:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Stefan Wahren <stefan.wahren@...e.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"dave.taht@...il.com" <dave.taht@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver
 for QCA7000

On Tue, 2014-07-01 at 18:46 +0100, Mark Rutland wrote:
> On Tue, Jul 01, 2014 at 05:36:49PM +0100, Stefan Wahren wrote:
> > This patch adds the Ethernet over SPI driver for the
> > Qualcomm QCA7000 HomePlug GreenPHY.
[]
> > +               memcpy(qca->net_dev->dev_addr, mac, ETH_ALEN);
> 
> I believe that it is preferred to write:
> 
> 	ether_addr_copy(qca->net_dev->dev_addr, mac);
> 
> I believe checkpatch has a warning for this.

True, but you have to make sure that both args are
at least __aligned(2) and afaics there's no
guarantee that's true for mac.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html