netdev - Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140702174815.GA8388@localhost.localdomain>
Date:	Wed, 2 Jul 2014 19:48:15 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>
Cc:	davem@...emloft.net, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks

On Wed, Jul 02, 2014 at 04:41:42PM +0200, Stefan Sørensen wrote:
> Replace two switch statements enumerating all valid ptp classes with an if
> statement matching for not PTP_CLASS_NONE.

Originally, I had the explicit list to guard against the possibility
of a filter returning early without some valid PTP_CLASS. I agree with
this change, but we will have to remember to make sure the filter
always returns NONE when the packet isn't recognized.

Acked-by: Richard Cochran <richardcochran@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html