netdev - Re: [PATCH] rcar_can: add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B46ADF.9070602@cogentembedded.com>
Date:	Thu, 03 Jul 2014 00:26:07 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Mark Rutland <mark.rutland@....com>,
	Marc Kleine-Budde <mkl@...gutronix.de>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"wg@...ndegger.com" <wg@...ndegger.com>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	"vksavl@...il.com" <vksavl@...il.com>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] rcar_can: add device tree support

Hello.

On 07/02/2014 02:14 PM, Mark Rutland wrote:

>>> Add support of the device tree probing for the Renesas R-Car CAN controllers
>>> documenting the device tree bindings as necessary.

[...]

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

[...]

>>> Index: net-next/Documentation/devicetree/bindings/net/can/rcar_can.txt
>>> ===================================================================
>>> --- /dev/null
>>> +++ net-next/Documentation/devicetree/bindings/net/can/rcar_can.txt
>>> @@ -0,0 +1,40 @@
[...]

>>> +- reg: physical base address and size of the R-Car CAN register map.
>>> +- interrupts: interrupt specifier for the sole interrupt.
>>> +- clocks: phandle and clock specifier for the R-Car CAN clock input.
>>> +- pinctrl-0: pin control group to be used for this controller.
>>> +- pinctrl-names: must be "default".
>>> +
>>> +Optional properties:
>>> +- clock-select: R-Car CAN Clock Source Select. Valid values are:
>>> +		<0x0> (default) : Peripheral clock (clkp1)
>>> +		<0x1> : Peripheral clock (clkp2)
>>> +		<0x3> : Externally input clock

> What's this for, and how does this interact with the single clock listed
> above?

    That's supposed to select a source for the CAN bus clock. Looking back at 
the driver, it seems to actually only support the value of 0. That's something 
we haven't given enough attention to clearly... :-/

> THanks,
> Mark.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html