netdev - Re: [PATCH v2] net: fix circular dependency in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140702.003128.935333350824361837.davem@davemloft.net>
Date:	Wed, 02 Jul 2014 00:31:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zonque@...il.com
Cc:	jeffm@...e.com, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: fix circular dependency in of_mdio code

From: Daniel Mack <zonque@...il.com>
Date: Sat, 28 Jun 2014 01:23:35 +0200

> Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a
> circular dependency between libphy and of_mdio.
> 
> depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
> dependency cycle!
> depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!
> 
> The problem is that of_mdio.c references &mdio_bus_type and libphy now
> references of_mdiobus_link_phydev.
> 
> Fix this by not exporting of_mdiobus_link_phydev() from of_mdio.ko.
> Make it a static function in mdio_bus.c instead.
> 
> Signed-off-by: Daniel Mack <zonque@...il.com>
> Reported-by: Jeff Mahoney <jeffm@...e.com>
> Fixes: 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
> ---
> v2: Provide a stub for of_mdiobus_link_phydev() for !CONFIG_OF_MDIO.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html