netdev - Re: [patch net-next] bonding: allow to add vlans on top of empty bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702090517.GA5440@unicorn.suse.cz>
Date:	Wed, 2 Jul 2014 11:05:17 +0200
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Jay Vosburgh <jay.vosburgh@...onical.com>,
	Tom Gundersen <teg@...m.no>, netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, vfalico@...il.com,
	andy@...yhouse.net
Subject: Re: [patch net-next] bonding: allow to add vlans on top of empty bond

On Wed, Jul 02, 2014 at 10:46:52AM +0200, Jiri Pirko wrote:
> Fri, Jun 27, 2014 at 06:08:50PM CEST, jay.vosburgh@...onical.com wrote:
> >
> >        if (!bond_has_slaves(bond)) {
> >                bond_set_carrier(bond);
> >                eth_hw_addr_random(bond_dev);
> >
> >                if (vlan_uses_dev(bond_dev)) {
> >                        pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
> >                                bond_dev->name, bond_dev->name);
> >                        pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
> >                                bond_dev->name);
> >                }
> >        }
> >
> >	This warning may not be useful any longer, since the MAC should
> >update correctly without user action when re-adding the first slave.
> 
> I just checked. The vlan dev holds its addr. So when new slave is added,
> bond addr is changed to it, but vlan addr remains the same. So the
> second warning still stands.

Is it a problem? Since we have proper uc_list propagation, vlan should
work even if its address doesn't match the bond.

                                                        Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html