netdev - Re: [patch net-next] bonding: remove no longer relevant vlan warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702120308.GA2596@mikrodark.usersys.redhat.com>
Date:	Wed, 2 Jul 2014 14:03:08 +0200
From:	Veaceslav Falico <vfalico@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, j.vosburgh@...il.com,
	andy@...yhouse.net, teg@...m.no, jay.vosburgh@...onical.com,
	mkubecek@...e.cz
Subject: Re: [patch net-next] bonding: remove no longer relevant vlan warnings

On Wed, Jul 02, 2014 at 11:55:38AM +0200, Jiri Pirko wrote:
>These warnings are no longer relevant. Even when last slave is
>removed, there is a valid address assigned to bond (random).
>The correct functionality of vlans is ensured by maintaining unicast
>list in vlan_sync_address().
>
>Suggested-by: Jay Vosburgh <jay.vosburgh@...onical.com>
>Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Thanks for following up on this.

Acked-by: Veaceslav Falico <vfalico@...il.com>

>---
> drivers/net/bonding/bond_main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index ffefb70..09dc3ef 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev,
> 	if (!bond_has_slaves(bond)) {
> 		bond_set_carrier(bond);
> 		eth_hw_addr_random(bond_dev);
>-
>-		if (vlan_uses_dev(bond_dev)) {
>-			pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
>-				bond_dev->name, bond_dev->name);
>-			pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
>-				bond_dev->name);
>-		}
> 	}
>
> 	unblock_netpoll_tx();
>-- 
>1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html