netdev - Re: [net-next PATCH v4 0/2] bridge: fdb dumping takes a filter device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140702.181958.175884390637356702.davem@davemloft.net>
Date:	Wed, 02 Jul 2014 18:19:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	vyasevic@...hat.com, sfeldma@...ulusnetworks.com,
	john.r.fastabend@...el.com, roopa@...ulusnetworks.com,
	eric.dumazet@...il.com
Subject: Re: [net-next PATCH v4 0/2] bridge: fdb dumping takes a filter
 device

From: David Miller <davem@...emloft.net>
Date: Wed, 02 Jul 2014 17:41:14 -0700 (PDT)

> Series applied, thanks Jamal.

Actually, I had to revert, this breaks the qlcnic build:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c: In function ‘qlcnic_fdb_dump’:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:440:3: warning: passing argument 4 of ‘ndo_dflt_fdb_dump’ makes pointer from integer without a cast [enabled by default]
In file included from include/net/dst.h:13:0,
                 from include/net/sock.h:68,
                 from include/linux/tcp.h:23,
                 from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:20,
                 from drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:11:
include/linux/rtnetlink.h:78:12: note: expected ‘struct net_device *’ but argument is of type ‘int’
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:440:3: error: too few arguments to function ‘ndo_dflt_fdb_dump’
In file included from include/net/dst.h:13:0,
                 from include/net/sock.h:68,
                 from include/linux/tcp.h:23,
                 from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:20,
                 from drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:11:
include/linux/rtnetlink.h:78:12: note: declared here
make[5]: *** [drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.o] Error 1

Also patch two had trailing whitespace, please fix that up with your
resubmission too, thanks.