netdev - Re: [PATCH net] net: fix sparse warning in sk_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 02 Jul 2014 17:03:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: fix sparse warning in sk_dst_set()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 02 Jul 2014 02:39:38 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> sk_dst_cache has __rcu annotation, so we need a cast to avoid
> following sparse error :
> 
> include/net/sock.h:1774:19: warning: incorrect type in initializer (different address spaces)
> include/net/sock.h:1774:19:    expected struct dst_entry [noderef] <asn:4>*__ret
> include/net/sock.h:1774:19:    got struct dst_entry *dst
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Fixes: 7f502361531e ("ipv4: irq safe sk_dst_[re]set() and ipv4_sk_update_pmtu() fix")

Applied and I'll make sure this gets passed along with I send 7f502361531e to -stable.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html