lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 03 Jul 2014 17:53:40 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>, davem@...emloft.net,
	stephen@...workplumber.org
CC:	netdev@...r.kernel.org, vyasevic@...hat.com,
	sfeldma@...ulusnetworks.com, john.r.fastabend@...el.com,
	roopa@...ulusnetworks.com, eric.dumazet@...il.com
Subject: Re: [net-next-2.6 PATCH v5 1/2] bridge: fdb dumping takes a filter
 device

On 07/03/2014 03:08 PM, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@...atatu.com>
>
> Dumping a bridge fdb dumps every fdb entry
> held. With this change we are going to filter
> on selected bridge port.
>
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c      |    3 ++-
>   drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    7 ++++---
>   include/linux/netdevice.h                        |    1 +
>   include/linux/rtnetlink.h                        |    1 +
>   net/bridge/br_fdb.c                              |    5 +++++
>   net/bridge/br_private.h                          |    2 +-
>   net/core/rtnetlink.c                             |    7 ++++---
>   7 files changed, 18 insertions(+), 8 deletions(-)
>
>
[...]

checkpatch.pl is giving the following warnings on this patch

WARNING: line over 80 characters
#30: FILE: drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:430:
+			struct net_device *netdev, struct net_device *filter_dev,

WARNING: line over 80 characters
#123: FILE: net/core/rtnetlink.c:2551:
+				idx = ops->ndo_fdb_dump(skb, cb, dev, NULL, idx);

WARNING: line over 80 characters
#128: FILE: net/core/rtnetlink.c:2555:
+			idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, dev, NULL, idx);

total: 0 errors, 3 warnings, 0 checks, 97 lines checked

-- 
Varka Bhadram

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists