netdev - Re: [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZOPZKrkVEZGoCfP3wgvSMSK+5qO0syxxoQhWqhF_oBbooHnQ@mail.gmail.com>
Date:	Sun, 6 Jul 2014 16:56:26 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Veaceslav Falico <vfalico@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address()

On Fri, May 23, 2014 at 12:22 AM, David Miller <davem@...emloft.net> wrote:
>
> From: Veaceslav Falico <vfalico@...il.com>
> Date: Thu, 22 May 2014 15:12:02 +0200
>
> > Currently rlb_enabled works as
> > rlb_enabled == (BOND_MODE(bond) == BOND_MODE_ALB)
> > so we can always use this verification and drop maintenance of this
> > variable.
> >
> > alb_set_mac_address(), OTOH, isn't used at all (as the mac changing logic
> > is used in other parts), and isn't ever called, so it's safe to remove it
> > as well.
> >
> > CC: Jay Vosburgh <j.vosburgh@...il.com>
> > CC: Andy Gospodarek <andy@...yhouse.net>
> > CC: netdev@...r.kernel.org
> > Signed-off-by: Veaceslav Falico <vfalico@...il.com>
>
> I agree with Jay's feedback and that you should:
>
> 1) Just go to the new MAC stash scheme in net-next instead of trying
>    to fix something you intend to immediately remove.
>
> 2) Something to fix this as minimally as possible for 'net' and
>    -stable should be done as well.
>
> I'm therefore not applying this series to the tree.

Hi Veaceslav ,

Just a reminder, any progress on this matter?

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html