netdev - Re: [PATCH] netlink: Fix netlink_recvmsg() handling of error from netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140707.193735.766947638929765410.davem@davemloft.net>
Date:	Mon, 07 Jul 2014 19:37:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	blp@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: Fix netlink_recvmsg() handling of error from
 netlink_dump().

From: Ben Pfaff <blp@...ira.com>
Date: Mon, 30 Jun 2014 15:35:04 -0700

> netlink_dump() returns a negative errno value on error.  Until now,
> netlink_recvmsg() directly recorded that negative value in sk->sk_err,
> but that's wrong since sk_err takes positive errno values.  (This manifests
> as userspace receiving a positive return value from the recv() system call,
> falsely indicating success.)
> 
> This bug was introduced in the commit that started checking the
> netlink_dump() return value, commit b44d211 (netlink: handle errors from
> netlink_dump()).
> 
> Multithreaded Netlink dumps are one way to trigger this behavior in
> practice, as described in the commit message for the userspace workaround
> posted here:
>     http://openvswitch.org/pipermail/dev/2014-June/042339.html
> 
> Signed-off-by: Ben Pfaff <blp@...ira.com>

There's another place, later in this file, doing the same exact thing.

Please respin this patch, fixing that location too.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html