netdev - Re: [PATCH net-next] enic: fix return values in enic_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140707.213402.533534622692381995.davem@davemloft.net>
Date:	Mon, 07 Jul 2014 21:34:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, benve@...co.com, ssujith@...co.com,
	ben@...adent.org.uk
Subject: Re: [PATCH net-next] enic: fix return values in enic_set_coalesce

From: Govindarajulu Varadarajan <_govind@....com>
Date: Wed,  2 Jul 2014 15:42:15 +0530

> enic_set_coalesce() has two problems.
> 
> * It should return -EINVAL and not -EOPNOTSUPP for invalid coalesce values.
> 
> * In case of MSIX, enic_set_coalesce return error after applying requested
>   coalescing setting partially. We should either apply all the setting requeste
>   and return success or apply non and return error.
> 
> * This patch also simplifies the algo.
> 
> This was introduced by
> '7c2ce6e60f703 enic: Add support for adaptive interrupt coalescing'
> 
> These changes were suggested by Ben Hutchings here
> http://www.spinics.net/lists/netdev/msg283972.html
> 
> Also change enic driver version.
> 
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html