netdev - Re: [PATCH] net: mvneta: fix operation in 10 Mbit/s mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140708.200210.1665388475429292104.davem@davemloft.net>
Date:	Tue, 08 Jul 2014 20:02:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.petazzoni@...e-electrons.com
Cc:	netdev@...r.kernel.org, jason@...edaemon.net, andrew@...n.ch,
	sebastian.hesselbarth@...il.com,
	gregory.clement@...e-electrons.com,
	linux-arm-kernel@...ts.infradead.org,
	ezequiel.garcia@...e-electrons.com, tawfik@...vell.com,
	nadavh@...vell.com, alior@...vell.com, stable@...r.kernel.org,
	maggie.mae.roxas@...il.com
Subject: Re: [PATCH] net: mvneta: fix operation in 10 Mbit/s mode

From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Date: Tue,  8 Jul 2014 10:49:43 +0200

> As reported by Maggie Mae Roxas, the mvneta driver doesn't behave
> properly in 10 Mbit/s mode. This is due to a misconfiguration of the
> MVNETA_GMAC_AUTONEG_CONFIG register: bit MVNETA_GMAC_CONFIG_MII_SPEED
> must be set for a 100 Mbit/s speed, but cleared for a 10 Mbit/s speed,
> which the driver was not properly doing. This commit adjusts that by
> setting the MVNETA_GMAC_CONFIG_MII_SPEED bit only in 100 Mbit/s mode,
> and relying on the fact that all the speed related bits of this
> register are cleared at the beginning of the mvneta_adjust_link()
> function.
> 
> This problem exists since c5aff18204da0 ("net: mvneta: driver for
> Marvell Armada 370/XP network unit") which is the commit that
> introduced the mvneta driver in the kernel.
> 
> Cc: <stable@...r.kernel.org> # v3.8+
> Fixes: c5aff18204da0 ("net: mvneta: driver for Marvell Armada 370/XP network unit")
> Reported-by: Maggie Mae Roxas <maggie.mae.roxas@...il.com>
> Cc: Maggie Mae Roxas <maggie.mae.roxas@...il.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html