netdev - Re: [PATCH resend] net: mvneta: Fix big endian issue in mvneta_txq_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140708.205208.1742283754280003313.davem@davemloft.net>
Date:	Tue, 08 Jul 2014 20:52:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fitzsim@...zsim.org
Cc:	netdev@...r.kernel.org, thomas.petazzoni@...e-electrons.com,
	jason@...edaemon.net, andrew@...n.ch,
	sebastian.hesselbarth@...il.com,
	gregory.clement@...e-electrons.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH resend] net: mvneta: Fix big endian issue in
 mvneta_txq_desc_csum()

From: Thomas Fitzsimmons <fitzsim@...zsim.org>
Date: Tue, 08 Jul 2014 19:44:07 -0400

> This commit fixes the command value generated for CSUM calculation
> when running in big endian mode.  The Ethernet protocol ID for IP was
> being unconditionally byte-swapped in the layer 3 protocol check (with
> swab16), which caused the mvneta driver to not function correctly in
> big endian mode.  This patch byte-swaps the ID conditionally with
> htons.
> 
> Cc: <stable@...r.kernel.org> # v3.13+
> Signed-off-by: Thomas Fitzsimmons <fitzsim@...zsim.org>
> ---
> The mvneta driver existed prior to v3.13, but it has only supported big
> endian from v3.13 onward.  If it's accepted, this patch needs to be
> backported for stable only as far back as v3.13.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html