netdev - Re: [RFC 7/7] net: don't check for active hrtimer after adding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BD1A56.7000902@arm.com>
Date:	Wed, 09 Jul 2014 11:32:54 +0100
From:	Chris Redpath <Chris.Redpath@....com>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>
CC:	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"preeti@...ux.vnet.ibm.com" <preeti@...ux.vnet.ibm.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Arvind Chauhan <Arvind.Chauhan@....com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC 7/7] net: don't check for active hrtimer after adding it

Hi Viresh,

On 09/07/14 07:55, Viresh Kumar wrote:
> hrtimer_start*() family never fails to enqueue a hrtimer to a clock-base. The
> only special case is when the hrtimer was in past. If it is getting enqueued to
> local CPUs's clock-base, we raise a softirq and exit, else we handle that on
> next interrupt on remote CPU.
>
> At several places in the kernel, we try to make sure if hrtimer was added
> properly or not by calling hrtimer_active(), like:
>
> 	hrtimer_start(timer, expires, mode);
> 	if (hrtimer_active(timer)) {
> 		/* Added successfully */
> 	} else {
> 		/* Was added in the past */
> 	}
>
> As hrtimer_start*() never fails, hrtimer_active() is guaranteed to return '1'.
> So, there is no point calling hrtimer_active().
>
> This patch updates net core to get this fixed.
>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>   net/core/pktgen.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index fc17a9d..f911acd 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2186,8 +2186,6 @@ static void spin(struct pktgen_dev *pkt_dev, ktime_t spin_until)
>   		do {
>   			set_current_state(TASK_INTERRUPTIBLE);
>   			hrtimer_start_expires(&t.timer, HRTIMER_MODE_ABS);
> -			if (!hrtimer_active(&t.timer))
> -				t.task = NULL;
>
>   			if (likely(t.task))
>   				schedule();

I think this if condition can also be removed. hrtimer_init_sleeper 
copies the supplied task_struct * to the timer, which in this case is 
'current'. The check is likely to be there in case of !active case you 
removed.

>

--Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html