[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADvbK_fBvG9WSMRWifJRUr6p-OQsZJL+MXC8LdDSbTEW8uSS4w@mail.gmail.com>
Date: Wed, 9 Jul 2014 09:51:02 +0800
From: lucien xin <lucien.xin@...il.com>
To: Cong Wang <cwang@...pensource.com>
Cc: network dev <netdev@...r.kernel.org>
Subject: Re: [PATCH] return the right retcode when add a unreachable route
On Wed, Jul 9, 2014 at 2:49 AM, Cong Wang <cwang@...pensource.com> wrote:
> On Sun, Jul 6, 2014 at 4:01 AM, Xin Long <lucien.xin@...il.com> wrote:
>
> This would potentially break user-space applications.
yes, you are right. if I only handle the -ESRCH , like:
- return __fib_lookup(net, flp, res);
+
+ err = __fib_lookup(net, flp, res);
+ if(err == -ESRCH)
+ return -ENETUNREACH;
+
+ return err;
I think it will be ok, after all, it looks confused that err is *No
such process* when add a route.
thanks for your reply.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists