netdev - Re: [PATCH net-next] sunvnet: call unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Jul 2014 07:27:26 -0400
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, dave.kleikamp@...cle.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH net-next] sunvnet: call unregister_netdev() exactly once
 per device

On 07/08/2014 11:42 PM, David Miller wrote:

>
> This is definitely not the right fix, you're just removing a symptom
> of a much larger problem.
>
> And that problem is that nothing cleans up the objects created by
> vnet_new(), they are completely leaked.

the bug(s) in modprobe -r is one manifestation of the problem
and should certainly be fixed, I can look into the suggestions
you have below.

But this is actually a bit worse. Whenever a node goes
away, it triggers a vio_port_remove() on all the peering nodes,
and blows away their networking. IOW this can happen without
involving vnet_exit() at all. Thus it might be necessary
for vio_port_remove() itself to check if its the last port
before doing the unregister?

BTW, for some odd reason I did not see my original patch submission
show up in the list. I'm not sure why.

>
> vnet_exit(), after doing the vio_unregister_driver(), should call a
> helper function that iterates over vnet_list and cleans up those
> objects.
>
> That's where the unregister_netdevice() belongs, not in vnet_port_remove().
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html