netdev - Re: [PATCH v2] hyperv: Add netpoll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53BD50B2.8050007@nod.at>
Date:	Wed, 09 Jul 2014 16:24:50 +0200
From:	Richard Weinberger <richard@....at>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	kys@...rosoft.com, haiyangz@...rosoft.com
CC:	romieu@...zoreil.com, devel@...uxdriverproject.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hyperv: Add netpoll support

Am 09.07.2014 16:13, schrieb Sergei Shtylyov:
> Hello.
> 
> On 07/09/2014 11:58 AM, Richard Weinberger wrote:
> 
>> In order to have at least a netconsole to debug kernel issues on
>> Windows Azure this patch implements netpoll support.
>> Sending packets is easy, netvsc_start_xmit() does already everything
>> needed.
> 
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>>   drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
> 
>> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
>> index 4fd71b7..45218d5 100644
>> --- a/drivers/net/hyperv/netvsc_drv.c
>> +++ b/drivers/net/hyperv/netvsc_drv.c
>> @@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
>>       return err;
>>   }
>>
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void netvsc_poll_controller(struct net_device *net)
>> +{
>> +    /* As netvsc_start_xmit() works synchronous we don't have to
>> +       trigger anything here. */
> 
>    The multi-line comment style in the networking code is this:
> 
> /* bla
>  * bla
>  */
> 
>> +    return;
> 
>    Not needed.
> 
>> +}
>> +#endif
> [...]

-ETOOMANYCODINGSTYLES :)

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html