netdev - Re: [PATCH net v2 4/7] net: cpmac: fix cpmac driver structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140710130812.GD15340@saruman.home>
Date:	Thu, 10 Jul 2014 08:08:12 -0500
From:	Felipe Balbi <balbi@...com>
To:	<varkabhadram@...il.com>
CC:	<netdev@...r.kernel.org>, <mugunthanvnm@...com>,
	<linux@...nbow-software.org>, <balbi@...com>,
	<george.cherian@...com>, <davem@...emloft.net>,
	Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net v2 4/7] net: cpmac: fix cpmac driver structure

On Thu, Jul 10, 2014 at 11:05:42AM +0530, varkabhadram@...il.com wrote:
> From: Varka Bhadram <varkab@...c.in>
> 
> This patch changes to style of declarattion which follows every driver
> 
> Signed-off-by: Varka Bhadram <varkab@...c.in>

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/net/ethernet/ti/cpmac.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> index 9faf669..1520c19 100644
> --- a/drivers/net/ethernet/ti/cpmac.c
> +++ b/drivers/net/ethernet/ti/cpmac.c
> @@ -1187,9 +1187,11 @@ static int cpmac_remove(struct platform_device *pdev)
>  }
>  
>  static struct platform_driver cpmac_driver = {
> -	.driver.name = "cpmac",
> -	.driver.owner = THIS_MODULE,
> -	.probe = cpmac_probe,
> +	.driver = {
> +		.name 	= "cpmac",
> +		.owner 	= THIS_MODULE,
> +	},
> +	.probe 	= cpmac_probe,
>  	.remove = cpmac_remove,
>  };
>  
> -- 
> 1.7.9.5
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)