netdev - Re: [PATCH net 1/7] net: cpmac: remove space in macro defination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1405006695.2796.3.camel@joe-AO725>
Date:	Thu, 10 Jul 2014 08:38:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <florian@...nwrt.org>,
	Varka Bhadram <varkabhadram@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	mugunthanvnm <mugunthanvnm@...com>,
	Ondrej Zary <linux@...nbow-software.org>, balbi@...com,
	george.cherian@...com, David Miller <davem@...emloft.net>,
	Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net 1/7] net: cpmac: remove space in macro defination

> 2014-07-09 21:47 GMT-07:00  <varkabhadram@...il.com>:
[]
> > diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> > index 7399a52..61eb691 100644
> > --- a/drivers/net/ethernet/ti/cpmac.c
> > +++ b/drivers/net/ethernet/ti/cpmac.c
> > @@ -67,42 +67,42 @@ MODULE_PARM_DESC(dumb_switch, "Assume switch is not connected to MDIO bus");
> >  #define CPMAC_RX_CONTROL               0x0014
> >  #define CPMAC_RX_TEARDOWN              0x0018
> >  #define CPMAC_MBP                      0x0100
> > -# define MBP_RXPASSCRC                 0x40000000
> > -# define MBP_RXQOS                     0x20000000
> > -# define MBP_RXNOCHAIN                 0x10000000
> > -# define MBP_RXCMF                     0x01000000
> > -# define MBP_RXSHORT                   0x00800000
> > -# define MBP_RXCEF                     0x00400000
> > -# define MBP_RXPROMISC                 0x00200000
> > -# define MBP_PROMISCCHAN(channel)      (((channel) & 0x7) << 16)
> > -# define MBP_RXBCAST                   0x00002000
> > -# define MBP_BCASTCHAN(channel)                (((channel) & 0x7) << 8)
> > -# define MBP_RXMCAST                   0x00000020
> > -# define MBP_MCASTCHAN(channel)                ((channel) & 0x7)

I think these are al relatively poor cleanups as
it is now no longer visually obvious that these
MBP_<FOO> defines are related to CPMAC_MBP

If you really want to do this I suggest something like:
#define CPMAC_MBP			0x0100
#define		MBP_RXPASSCRC		0x40000000



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html