netdev - Re: [PATCH] bonding: Do not try to send packets over dead link in TLB mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jul 2014 10:25:01 +0200
From:	Maciej Żenczykowski <zenczykowski@...il.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	Mahesh Bandewar <maheshb@...gle.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jay Vosburgh <j.vosburgh@...il.com>
Subject: Re: [PATCH] bonding: Do not try to send packets over dead link in TLB mode.

>> Please note that I got this assert-fail on 3.10 kernel and haven't
>> verified if things have changed in mii_monitor context since then.
>>
> Okay, this is definitely it. Moreover I cannot find
> "bond_handle_link_change" function in any bonding version, google search
> also shows up empty.
>
> Could you please test this patch with the tree that it is intended for ?
> I'm pretty certain that there won't be any problem.
>
> And one more thing, please update the CC list, Jay's email now is:
> j.vosburgh@...il.com
> according to the MAINTAINERS file.

Mahesh you're running into one of the 2 or 3 internal bonding mode
changes that haven't been upstreamed.
Some sort of lacp churn machine and faster/better link up/down/change
notification propagation are among them.
We really should clean those up and get them submitted.

You should probably do this development on upstream 3.15 ;-)

- Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html